Update contributing.md #2834
Merged
Update contributing.md #2834
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
list guidelines-->list of guidelines Fixed the typo.
|
"List guidelines" was imo referring to all the guidelines of the list, which also include awesome.md and contributing.md. "List of guidelines" changes the meaning to only the guidelines as stated in the pr template. In my opinion therefore this change was unnecessary, but I might be wrong because english is not my native language. |
Arthur-xu
added a commit
to Arthur-xu/awesome
that referenced
this pull request
Nov 13, 2023
* Add Steam Deck (sindresorhus#2743) * Update link to Awesome Mastodon (sindresorhus#2739) * Add Pest (sindresorhus#2601) * Add HPC (sindresorhus#2640) * Update guidelines * Add Biological Image Analysis (sindresorhus#2620) Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com> * Move Esolangs into "Programming Languages" section (sindresorhus#2799) * Add Prompt Injection (sindresorhus#2734) * Meta tweaks * Add Complexity (sindresorhus#2389) * Fix typo (sindresorhus#2834) * Fix typos (sindresorhus#2835) * Meta tweaks --------- Co-authored-by: Francesco Sardone <francesco@airscript.it> Co-authored-by: Edwin Kofler <edwin@kofler.dev> Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com> Co-authored-by: akail <andrew.a.kail@gmail.com> Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com> Co-authored-by: Hallvard A. Wæhler <60000604+hallvaaw@users.noreply.github.com> Co-authored-by: Sam Partington <sampart@github.com> Co-authored-by: Hazana <hazanasec@gmail.com> Co-authored-by: Diamantis Sellis <sellisd@gmail.com> Co-authored-by: Vivek Gurudutt K <127002789+VivekGuruduttK28@users.noreply.github.com> Co-authored-by: S A G A R <110724849+tmsagarofficial@users.noreply.github.com>
KFCMULLBANK
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Insert URL to the list here]
N/A
[Explain what this list is about and why it should be included here]
list guidelines-->list of guidelines
Fixed the typo.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
All the below section wouldnt apply because this is a typo fix