Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft Sentinel #2753

Closed
wants to merge 8 commits into from
Closed

Add Microsoft Sentinel #2753

wants to merge 8 commits into from

Conversation

kfriede
Copy link

@kfriede kfriede commented Aug 18, 2023

https://github.com/kfriede/awesome-microsoft-sentinel

Resources for Microsoft Azure Sentinel and related KQL, SIEM, and SOAR functionality

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List. It should not contain the word Awesome.
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
  • Your entry should be added at the bottom of the appropriate category.
  • The title of your entry should be title-cased and the URL to your list should end in #readme.
  • No blockchain-related lists.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
  • It's the result of hard work and the best I could possibly produce.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
  • The heading title of your list should be in title case format: # Awesome Name of List.
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
  • Has a Table of Contents section.
  • Has an appropriate license.
  • Has contribution guidelines.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
  • Does not use hard-wrapping.
  • Does not include a CI (e.g. GitHub Actions) badge.
    You can still use a CI for linting, but the badge has no value in the readme.
  • Does not include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@kfriede
Copy link
Author

kfriede commented Aug 21, 2023

@sindresorhus I went through line-by-line when I checked everything off. Would you care to inform me what I'm missing so I can fix it?

@kfriede
Copy link
Author

kfriede commented Aug 23, 2023

unicorn 🦄

@donBarbos
Copy link

It seems this and this repositories already covers your topic

Also, your repository may not fit these criteria:

- [ ] It's the result of hard work and the best I could possibly produce.
	**If you have not put in considerable effort into your list, your pull request will be immediately closed.**

Copy link

@iamhonest1 iamhonest1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️

@infosecB
Copy link
Contributor

  • Recommend renaming repo to "awesome-azure-sentinel" or "awesome-microsoft-sentinel"
  • Pull request title should match name of repo (e.g. without above change, "Add Sentinel")

@infosecB infosecB mentioned this pull request Oct 24, 2023
34 tasks
@kfriede
Copy link
Author

kfriede commented Oct 25, 2023

  • Recommend renaming repo to "awesome-azure-sentinel" or "awesome-microsoft-sentinel"
  • Pull request title should match name of repo (e.g. without above change, "Add Sentinel")

Updated repository name, no PR name change required (since repository name now matches PR)

@kfriede
Copy link
Author

kfriede commented Oct 25, 2023

unicorn 🦄

Copy link

@emmanuelgautier emmanuelgautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelgautier emmanuelgautier mentioned this pull request Feb 13, 2024
32 tasks
Repository owner deleted a comment from Gnssrl Feb 14, 2024
@@ -643,6 +643,7 @@
- [Password Cracking](https://github.com/n0kovo/awesome-password-cracking#readme) - The process of recovering passwords from data that has been stored in or transmitted by a system in scrambled form.
- [Security Card Games](https://github.com/Karneades/awesome-security-card-games#readme) - Train your skills and discuss various security topics.
- [Suricata](https://github.com/satta/awesome-suricata#readme) - Intrusion detection/prevention system and network security monitoring engine.
- [Microsoft Sentinel](https://github.com/kfriede/awesome-microsoft-sentinel#readme) - Microsoft Sentinel cloud-native SIEM/SOAR solution.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should not contain the list title. Also not clear what SIEM/SOAR is. Needs a better description in general.

@sindresorhus
Copy link
Owner

The list is a bit thin on content.

@sindresorhus
Copy link
Owner

It's also not following multiple of the guidelines, like . at the end of descriptions. I suggest working on it some more and try submitting it again at a later point (at least wait 6 months).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants