-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DevOps #2470
Add DevOps #2470
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Update the link as per requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi wmariuss,
After running npx awesome-lint https://github.com/wmariuss/awesome-devops
from my terminal, I found the below 36 issues that fixing:
- ✖ 1:1 Missing Awesome badge after the main heading remark-lint:awesome-badge, which means you need to add the
awesome-bage
right afterAwesome DevOps
heading not after the break. - ✖ 1:1 Forbidden license section found remark-lint:awesome-license,
- ✖ 23:1 ToC item "Observability and Monitoring" does not match corresponding heading "Observability & Monitoring" remark-lint:awesome-toc
- ✖ 68:85 "’" is used without matching "‘" remark-lint:match-punctuation
- ✖ 137:41 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 148:42 List item description must end with proper punctuation remark-lint:awesome-list-item
- ✖ 158:37 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 159:74 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 160:38 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 161:44 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 162:43 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 163:43 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 165:52 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 166:56 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 168:33 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 173:43 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 173:139 "’" is used without matching "‘" remark-lint:match-punctuation
- ✖ 174:53 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 175:34 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 179:40 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 179:73 "’" is used without matching "‘" remark-lint:match-punctuation
- ✖ 180:39 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 182:40 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 183:40 List item description must start with valid casing remark-lint:awesome-list-item
- ✖ 185:6 Text "Github" should be written as "GitHub" remark-lint:awesome-spell-check
- ✖ 193:4 Text "Github" should be written as "GitHub" remark-lint:awesome-spell-check
- ✖ 195:46 List item description must end with proper punctuation remark-lint:awesome-list-item
- ✖ 205:3 http://nginx.org/ remark-lint:double-link
- ✖ 216:69 "’" is used without matching "‘" remark-lint:match-punctuation
- ✖ 217:7 "’" is used without matching "‘" remark-lint:match-punctuation
- ✖ 298:3 https://konghq.com/ remark-lint:double-link
- ✖ 318:3 https://konghq.com/ remark-lint:double-link
- ✖ 318:90 "’" is used without matching "‘" remark-lint:match-punctuation
- ✖ 324:3 https://nginx.org/ remark-lint:double-link
- ✖ 412:3 https://landing.google.com/sre/books/ remark-lint:double-link
- ✖ 413:3 https://landing.google.com/sre/books remark-lint:double-link
I know. Fixing it. |
Hi @wmariuss Wow, awesome list! A few comments:
|
Thanks for the feedback. I will take a look to the changes later. |
unicorn |
Hi @wmariuss, thanks for the list! I suggest using heading levels where relevant instead of second level bullet points, e.g.
Instead of:
I also think below category descriptions are unnecessarily redundant. |
The linter returns 31 errors ✖ 1:1 Missing Awesome badge after the main heading remark-lint:awesome-badge 31 errors |
HI @wmariuss , Thanks for the list. Could you please check below items once.
|
Closing for lack of response. |
https://github.com/wmariuss/awesome-devops
Combine the platforms, tools, practice and resources to create and improve DevOps culture, as well Site Reliability Engineering in a org.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.