Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Master CSS #2382

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Add Master CSS #2382

merged 4 commits into from
Dec 7, 2022

Conversation

0Lola
Copy link
Contributor

@0Lola 0Lola commented Sep 16, 2022

https://github.com/master-co/awesome-master-css#readme

Master CSS is a virtual CSS language with enhanced syntax, efficiently build your UI and design system with HTML only.

Reviewed PRs:

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.

  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.

  • You have read and understood the instructions for creating a list.

  • This pull request has a title in the format Add Name of List.

    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • add Swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.

    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.

  • The title of your entry should be title-cased and the URL to your list should end in #readme.

    • Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't use hard-wrapping.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@sellisd
Copy link
Contributor

sellisd commented Sep 16, 2022

It is a rather short list but linter and all requirements are met, great job!

@villesundell
Copy link
Contributor

The layout and visual choices are great, as said above it's a bit short though. The list passes lint, and commit passes the guidelines 👍

However, you haven't followed the guidelines the whole way through, please review once again 🙂

@villesundell villesundell mentioned this pull request Sep 16, 2022
Copy link
Contributor

@alex-semenyuk alex-semenyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this awesome list. Looks good!
Please correct this link https://github.com/master-co/awesome-master-css/blob/main/CONTRIBUTING.md for README.

@alex-semenyuk alex-semenyuk mentioned this pull request Sep 16, 2022
@0Lola
Copy link
Contributor Author

0Lola commented Sep 17, 2022

Thanks for this awesome list. Looks good! Please correct this link https://github.com/master-co/awesome-master-css/blob/main/CONTRIBUTING.md for README.

@alex-semenyuk

Thanks for your review!

I have fixed the URL of the contribution guidelines. 👍

@villesundell
Copy link
Contributor

@0Lola Also, regarding your message #2242 (comment): please note that the guidelines explicitly forbids work-in-progress PRs. When PR is opened, the list should be ready.

@0Lola
Copy link
Contributor Author

0Lola commented Sep 17, 2022

@0Lola Also, regarding your message #2242 (comment): please note that the guidelines explicitly forbids work-in-progress PRs. When PR is opened, the list should be ready.

@villesundell
I delete Started Master CSS under #2242 (comment) , thanks for your reminder!

@0Lola
Copy link
Contributor Author

0Lola commented Sep 17, 2022

unicorn

@sellisd sellisd mentioned this pull request Sep 21, 2022
@n0kovo
Copy link
Contributor

n0kovo commented Sep 21, 2022

This looks great! Only thing I can think of is, personally I like a little description of the categories below each title, but that's just me. It seems everything is as it should be. Thanks for making an awesome-list!

@n0kovo n0kovo mentioned this pull request Sep 21, 2022
@sindresorhus
Copy link
Owner

Linkify Master CSS in Master CSS is a virtual CSS language with enhanced syntax, efficiently build your UI and design system with HTML only. to the project website.

@sindresorhus
Copy link
Owner

You need to fix the merge conflict.

@0Lola
Copy link
Contributor Author

0Lola commented Nov 21, 2022

unicorn

unicorn not working, force pushing and run lint.
@0Lola
Copy link
Contributor Author

0Lola commented Nov 21, 2022

Hi @sindresorhus,

The following items adjusted:

  • Linkify Master CSS to the project website.
  • Fix the merge conflict.

By the way, the additional commit Fix lint checks is because I commented unicorn but the workflow didn't re-run.

Thanks for your review and suggestions!

@sindresorhus sindresorhus merged commit da84280 into sindresorhus:main Dec 7, 2022
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1600486513330061315

alex-semenyuk pushed a commit to alex-semenyuk/awesome that referenced this pull request Feb 19, 2023
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants