Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bigtable #2370

Closed
wants to merge 3 commits into from
Closed

Add Bigtable #2370

wants to merge 3 commits into from

Conversation

zrosenbauer
Copy link

@zrosenbauer zrosenbauer commented Sep 7, 2022

https://github.com/zrosenbauer/awesome-bigtable

Bigtable is a fully managed, scalable NoSQL database service for large analytical and operational workloads, built and managed by Google.

Note: I cannot change the license without direct approval from Google's legal team (so not going to happen).

Pull Requests Reviewed:

  1. Lint with awesome-lint via GitHub Actions #1794
  2. Add ZeroNet #2327

Copy link
Contributor

@aleixmorgadas aleixmorgadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zrosenbauer for the PR!

I'm reviewing it, and I think you missed some of the guidelines. I will point out the main ones 👍

You have to review at least 2 other open pull requests.

You need to point in the PR which other PR you reviewed.

We strongly recommend the CC0 license, but any Creative Commons license will work.

Tip: You can quickly add it to your repo by going to this URL: https://github.com///community/license/new?branch=main&template=cc0-1.0 (replace and accordingly).

A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.

I see you're using MIT. Please, consider using CC0 License.

Edit: Now I saw your note of needing Google's Approval to change the License


Those are the main things I saw! I hope it helps! 😄

readme.md Outdated Show resolved Hide resolved
@zrosenbauer
Copy link
Author

@aleixmorgadas Added the PRs (I thought I reviewed more back in the day but guess not I think I just went and opened PRs on the repos with issues 😄)

For Reference:

  1. Lint with awesome-lint via GitHub Actions #1794
  2. Add ZeroNet #2327

Also there is no way I can change that License without getting lawyers involved so its a no go (I don't work at Google and never have, I just had contributors from Google).

@zrosenbauer
Copy link
Author

Also... I forgot to add unicorn 🦄

@zolagonano
Copy link
Contributor

@zrosenbauer

Your awesome list's license shouldn't have anything to do with google and BigTable, because you're not using their software to build your own or anything like that which might require license compatibilities, you're just making a list out of public data and the license of it is only about your list, also the MIT license is a code/software license and its not quite good for licensing other types of content.

Note: The MIT license is not compatible with BigTable's license either, so even if it requires license compatibility, the MIT license wouldn't help.

@zolagonano zolagonano mentioned this pull request Sep 8, 2022
@notpresident35 notpresident35 mentioned this pull request Sep 11, 2022
@zrosenbauer
Copy link
Author

@zolagonano Employees of Google have contributed to the repository. This means that Google owns the contributions of said employees aka to relicense I need Google's approval (this is from the Bigtable Lead Engineer directly... zrosenbauer/awesome-bigtable#8). If I were to change that, Google wouldn't allow future contributions from those employees (which means that a awesome list about a Google built product can't be contributed to by Google).

The best I could do is say from before date X -> MIT, moving forward CC0 (which is also on the Google banned list).

@zrosenbauer
Copy link
Author

Google banned OSS License list -> https://opensource.google/documentation/reference/patching#forbidden

I could look at this one -> https://creativecommons.org/licenses/by/4.0/

@zrosenbauer
Copy link
Author

@sindresorhus any guidance here on the License issue above (I think thats the last piece here of this puzzle)

Short description of issue: I originally licensed as MIT (my default) and didn't realize it would conflict with the standards in this repository (I didn't realize the awesome list existed, just saw others in the wild). Google employees contributed to the repository on behalf of Google & I can't switch the license without Google's approval. The best I can do is a stop / start with the new license (recommendation from an engineer there). Also the CC* licenses are apparently banned by Google Legal 😢 ...

If we can resolve this I'd happily help build out a license migration document (unless there is one I'm missing...)

@sindresorhus
Copy link
Owner

I could look at this one -> https://creativecommons.org/licenses/by/4.0/

This is an acceptable license too.

readme.md Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Add Google Bigtable Add Bigtable Nov 20, 2022
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus
Copy link
Owner

Closing for lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants