Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Neovim #2053

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Add Neovim #2053

merged 1 commit into from
Nov 26, 2021

Conversation

tversteeg
Copy link
Contributor

https://github.com/rockerBOO/awesome-neovim

This list lists plugins for the neovim text editor.

@sindresorhus
Copy link
Owner

sindresorhus commented Sep 9, 2021

Thanks for submitting an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@stn1slv
Copy link
Contributor

stn1slv commented Sep 9, 2021

You have missed unicorn and check the license for the repo.

@stn1slv stn1slv mentioned this pull request Sep 9, 2021
@tversteeg
Copy link
Contributor Author

unicorn

@sindresorhus
Copy link
Owner

Includes a succinct description of the project/theme at the top of the readme. (Example) - https://github.com/sindresorhus/awesome/blob/main/pull_request_template.md

@sindresorhus
Copy link
Owner

The link and description are separated by a dash.
Example: - AVA - JavaScript test runner.
The description starts with an uppercase character and ends with a period.

Some items are not in this format.

@sindresorhus
Copy link
Owner

Bump

@tversteeg
Copy link
Contributor Author

The link and description are separated by a dash.
Example: - AVA - JavaScript test runner.
The description starts with an uppercase character and ends with a period.

Some items are not in this format.

FIxed this.

Includes a succinct description of the project/theme at the top of the readme. (Example) - main/pull_request_template.md

I don't understand this. Isn't "Collections of awesome Neovim plugins. Mostly targeting Neovim specific features." succinct enough?

@sindresorhus
Copy link
Owner

I don't understand this. Isn't "Collections of awesome Neovim plugins. Mostly targeting Neovim specific features." succinct enough?

Yes, but it doesn't actually describe what it's asking for. It's asking for a description of the project/theme, not what the list contains. Please look at the examples in the guidelines.

@tversteeg
Copy link
Contributor Author

Understood, is the current description good enough?

@sindresorhus sindresorhus merged commit 0c8952c into sindresorhus:main Nov 26, 2021
@sindresorhus
Copy link
Owner

sindresorhus pushed a commit that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants