-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Audit Algorithms #2023
Add Audit Algorithms #2023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @erwanlemerrer, from looking at other PRs, I think your unicorn
comment needs to be stand-alone. Additionally, I think you need to put your reviewed PRs in the description of the PR.
Looking at your list, it does not follow the format of other awesome lists. I would suggest removing the table format, and moving all of the links into the preferred list format. Although it does pass the linter, I believe that the list is not in the spirit of other lists on this page.
Additionally, this list doesn't include anything more than academic papers. It would be nice to include links to implementations in code, projects using these algorithms, and other online resources.
@sindresorhus Hi, what can I do to support this PR please ? |
I think it would be useful if the list had a little bit more verbose description about the topic. I'm talking about this part: "A curated list of audit algorithms for getting insights from black-box algorithms.". I think the description column should come right after the title columns. I find the use of table makes the list harder to read and scan than a plain list and it's also harder to contribute to. |
👍 |
Also it would be nice to categorize these papers. It would be more easier to explore |
Bump |
@sindresorhus would that simple format more suitable ? https://github.com/aliyesilkanat/awesome-audit-algorithms thanks (will then add the larger description you called for) |
bec7823
to
6759a87
Compare
c9f7039
to
4b3a8e2
Compare
Yes, but they should still include descriptions. |
@sindresorhus Done as asked. Thanks |
|
Make sure the list follows all the guidelines. |
Indeed, now lint passed fine, sorry about that. |
@sindresorhus anything else I can do that could help? |
0fdf977
to
ec33c66
Compare
[Insert URL to the list here]
https://github.com/erwanlemerrer/awesome-audit-algorithms
[Explain what this list is about and why it should be included here]
A curated list of audit algorithms for getting insights from black-box algorithms.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.