-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run awesome-lint
on new additions
#1962
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sindresorhus have I addressed your concerns? |
sindresorhus
changed the title
auto awesome-lint any list added to the readme in a PR (again)
Run Apr 19, 2021
awesome-lint
on new additions
Thanks :) |
@RayBB The scripts throws an error: https://github.com/sindresorhus/awesome/pull/1990/checks?check_run_id=2468601026 |
Tolito20
reviewed
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Galván Gómez
Repository owner
deleted a comment from
HOP01
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is a repeat of #1851 since the fork or original fork was deleted. This PR address comments there.
I really appreciate this project and wanted to try to give back so it's a little easier for everyone involved.
To that end, I created this PR to automatically lint new lists when someone opens a PR to add them.
Benefits
awesome-lint
Risks
What it does
How it does it
This PR creates a GitHub action that will do the following every time a new commit is pushed to an open PR:
git diff
awesome-lint
on that repo.The above 3 steps will ONLY run if
readme.md
is changed.If readme is changed and no new URL is detected in the readme it will NOT fail with a helpful error message.
Error can be ignored if it is a cosmetic PR
Here are examples of failing commits.
Final notes
"Squash and Merge" this PR or let me know and I will squash it manually.
Feel free to edit this any way you see fit or ask me to make the edits. 👍
If there are any questions on how this works drop them here and I'll try my best to answer.
Again, thanks so much for all the hard work the maintainers put into this repo! 👏