-
-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Svelte #1898
Add Svelte #1898
Conversation
unicorn |
According to awesome-lint there are some errors.
Then type awesome-lint from the same prompt followed by the link of awesome repository you want to analyze, in your case:
Finally, the introduction on the contribution should be made at the end of the list under the title "Contributing". |
Interesting, had no errors locally, will check again, thx. |
This is optional right? |
It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content. I was wrong, you can write the introduction even at the top, but, from what I understand, you still have to put the title "Contributing". |
If you want to write the introduction to the contribution. |
I have a valid |
lgtm and passes awesome-lint locally. I don't see an issue with how contribution info is handled in the readme, the guidelines are in their own file and much more descriptive, but I see how it can be interpreted that it isn't following the style guide. |
The linter gives also no errors on my systems. The list looks fine from my point of view. Never heard of Svelt before, thanks for sharing. |
All the errors have been fixed and this is now compliant with all the rules. |
Repeating the name in the description is moot. Please go through all the descriptions and try to improve/simplify them. Some items are missing a description. Don't use emojis in descriptions. Descriptions should not be title-case.
Leaflet is a name. |
Done, some items do not require a description such as |
⬇️
|
Done, Thanks 👍🏼 (thought simple brand icons was a name). |
https://github.com/TheComputerM/awesome-svelte
Svelte is a new and upcoming compiler that compiles to js and makes faster apps as there is no almost no runtime,
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.