Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hyperledger Fabric #1769

Closed
wants to merge 3 commits into from

Conversation

Salmandabbakuti
Copy link

@Salmandabbakuti Salmandabbakuti commented May 12, 2020

*Add hyperledger fabric

Signed-off-by: Salmandabbakuti Salmandabbakuti@github.com

[https://github.com/wearetheledger/awesome-hyperledger-fabric]

[A curated list of resources for creating applications with Hyperledger Fabric]

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

*Adding hyperledger blockchain framework resources to the list.

Signed-off by Salmandabbakuti <Salmandabbakuti@github.com>
@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

readme.md Outdated Show resolved Hide resolved
@schlessera
Copy link
Contributor

The following error are still reported by awesome-lint:

Line:Column Error
1:1 License was not detected by GitHub
1:31 Invalid badge source
53:95 Text "Nodejs" should be written as "Node.js"
63:33 List item description must end with proper punctuation
67:112 Text "Nodejs" should be written as "Node.js"
68:114 Text "Nodejs" should be written as "Node.js"
70:116 Text "Nodejs" should be written as "Node.js"
86:3 Invalid list item link URL
92:155 Text "Youtube" should be written as "YouTube"
93:145 Text "youtube" should be written as "YouTube"
108:3 Invalid list item link URL
118:37 "’" is used without matching "‘"
119:195 List item description must end with proper punctuation
130:4 Text "Nodejs" should be written as "Node.js"
130:14 "’" is used without matching "‘"
149:4 Text "Nodejs" should be written as "Node.js"
150:4 Text "Nodejs" should be written as "Node.js"
158:159 List item description must end with proper punctuation

*Adding item to the bottom of the list.
@schlessera schlessera mentioned this pull request May 12, 2020
@kt3k
Copy link
Contributor

kt3k commented May 13, 2020

@Salmandabbakuti I think the PR title should be Add Hyperledger Fabric to follow the guideline. And you should also replace [Insert URL to the list here] part of the description with https://github.com/wearetheledger/awesome-hyperledger-fabric.

@Salmandabbakuti Salmandabbakuti changed the title Adding Hyperledger Fabric resources to the List Add Hyperledger Fabric May 14, 2020
@kt3k kt3k mentioned this pull request May 15, 2020
@stingalleman
Copy link
Contributor

There are still 26 errors found by awesome-lint.
Also, where are your reviewed pull requests?

You have to review at least 2 other open pull requests.
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.

@stingalleman stingalleman mentioned this pull request May 16, 2020
@Salmandabbakuti
Copy link
Author

I reviewed #1753 , #1762

@seriousran
Copy link
Contributor

seriousran commented May 29, 2020

There are still 23 errors found by awersome-lint in your list

✖ Linting

readme.md:76:3
✖ 1:1 License was not detected by GitHub remark-lint:awesome-github
✖ 1:31 Invalid badge source remark-lint:awesome-badge
✖ 53:95 Text "Nodejs" should be written as "Node.js" remark-lint:awesome-spell-check
✖ 63:33 List item description must end with proper punctuation remark-lint:awesome-list-item
✖ 67:112 Text "Nodejs" should be written as "Node.js" remark-lint:awesome-spell-check
✖ 68:114 Text "Nodejs" should be written as "Node.js" remark-lint:awesome-spell-check
✖ 70:116 Text "Nodejs" should be written as "Node.js" remark-lint:awesome-spell-check
✖ 76:3 Link to https://composer-playground.mybluemix.net is dead remark-lint:no-dead-urls
✖ 86:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 92:155 Text "Youtube" should be written as "YouTube" remark-lint:awesome-spell-check
✖ 93:145 Text "youtube" should be written as "YouTube" remark-lint:awesome-spell-check
✖ 108:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 118:37 "’" is used without matching "‘" remark-lint:match-punctuation
✖ 119:195 List item description must end with proper punctuation remark-lint:awesome-list-item
✖ 122:3 Link to https://developer.ibm.com/code/2018/05/11/two-enter-one-leaves/ is dead remark-lint:no-dead-urls
✖ 130:3 Link to https://medium.com/wearetheledger/a-beginners-guide-to-sidedbs-and-private-data-for-hyperledger-fabric-nodejs-chaincode-38d2c1bee198 is dead remark-lint:no-dead-urls
✖ 130:4 Text "Nodejs" should be written as "Node.js" remark-lint:awesome-spell-check
✖ 130:14 "’" is used without matching "‘" remark-lint:match-punctuation
✖ 149:4 Text "Nodejs" should be written as "Node.js" remark-lint:awesome-spell-check
✖ 150:4 Text "Nodejs" should be written as "Node.js" remark-lint:awesome-spell-check
✖ 153:3 Link to https://www.linkedin.com/pulse/origins-hyperledger-fabric-maciek-jędrzejczyk/ is dead remark-lint:no-dead-urls
✖ 158:159 List item description must end with proper punctuation remark-lint:awesome-list-item
✖ 163:3 Link to https://wiki.hyperledger.org/projects/fabric is dead remark-lint:no-dead-urls

23 errors

@ecklf
Copy link
Contributor

ecklf commented May 29, 2020

You are missing a license file in your project root

Also, I don't know how serious this is but your logo is not exactly at the far top right.

@ecklf ecklf mentioned this pull request May 31, 2020
@stingalleman stingalleman mentioned this pull request Jun 15, 2020
@schlessera schlessera mentioned this pull request Jun 15, 2020
@stingalleman stingalleman mentioned this pull request Mar 20, 2021
@othrbot othrbot mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants