-
-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sitecore #1747
Add Sitecore #1747
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Thanks for the submission! There are a number of issues with this submission, here are the top ones:
|
Added logo, made all the links aligned with the requirements (dots, cases, spaces, more), got rid of duplicated and spell checks, added license and contribution, few more minors |
unicorn |
The above is done. |
The submission looks fine for me. |
So, 30 days have passed. The list complies with the guidance. Linter also passes well |
readme.md
Outdated
@@ -508,6 +508,7 @@ | |||
- [Textpattern](https://github.com/drmonkeyninja/awesome-textpattern#readme) - Lightweight PHP-based CMS. | |||
- [Drupal](https://github.com/nirgn975/awesome-drupal#readme) - Extensible PHP-based CMS. | |||
- [Craft CMS](https://github.com/craftcms/awesome#readme) - Content-first CMS. | |||
- [Sitecore](https://github.com/MartinMiles/Awesome-Sitecore) - Sitecore Experience Platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
✅ - iOS - Mobile operating system for Apple phones and tablets.
✅ - Framer - Prototyping interactive UI designs.
❌ - iOS - Resources and tools for iOS development.
❌ - Framer
❌ - Framer - prototyping interactive UI designs
You also need to add #readme
|
@sindresorhus renamed the entry as per your request. Now looking explanatory. |
Looking forward for the merge, @sindresorhus please let me know if there's anything else left to get changed |
readme.md
Outdated
@@ -508,6 +508,7 @@ | |||
- [Textpattern](https://github.com/drmonkeyninja/awesome-textpattern#readme) - Lightweight PHP-based CMS. | |||
- [Drupal](https://github.com/nirgn975/awesome-drupal#readme) - Extensible PHP-based CMS. | |||
- [Craft CMS](https://github.com/craftcms/awesome#readme) - Content-first CMS. | |||
- [Sitecore](https://github.com/MartinMiles/Awesome-Sitecore) - A robust digital marketing system that combines CMS with contextual intelligence and omnichannel automation technologies. It also offers a rich variety of tools out of the box for emailing, analytics, campaigns and marketing automation tools for managing website(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too verbose. See the other descriptions for inspiration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too verbose. See the other descriptions for inspiration.
Provided less verbose description.
You did not fully read my comment in #1747 (comment) |
#1747 (comment) is not resolved. |
You cannot just copy-paste the contributing guidelines for Awesome: https://github.com/MartinMiles/awesome-sitecore/blob/master/contributing.md |
Run https://github.com/sindresorhus/awesome-lint on your list and ensure it passes. |
Linter passes well and returns no errors other than "remark-lint:no-dead-urls" which gives a false negative for the majority of links from the list, claiming these links are dead. In fact, they are not dead and that could be easily prove by opening any of them. Something might be wrong with awesome-lint tool |
Of course (silly me!). That has now been fixed by providing the relevant guidance for awesome-sitecore list |
@sindresorhus , all 3 issues have been fixed:
|
@sindresorhus do you mind merging my list, unless there is something else left for me to do? |
|
Done |
In |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
https://github.com/MartinMiles/Awesome-Sitecore
A missing list for such a top-rated CMS as Sitecore
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.