Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Awesome Azure Learning #1725

Closed
wants to merge 1 commit into from
Closed

Conversation

ddneves
Copy link

@ddneves ddneves commented Mar 7, 2020

added reference for Awesome Azure learning in README.

[Insert URL to the list here]

[Explain what this list is about and why it should be included here]

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

added reference for Awesome Azure learning in README.
@ddneves ddneves changed the title Added Awesome Azure learning Add Awesome Azure Learning Mar 7, 2020
@chrislatorres
Copy link
Contributor

chrislatorres commented Mar 8, 2020

Hi! This PR is missing two important parts right away, see at the top of this PR:

[Insert URL to the list here]

[Explain what this list is about and why it should be included here]

@chrislatorres chrislatorres mentioned this pull request Mar 8, 2020
@ddneves
Copy link
Author

ddneves commented Mar 8, 2020

Hey, thanks for coming back!

Link: https://github.com/ddneves/awesome-azure-learning

Intention: This repo is containing all resources to learn about Azure, Azure Architecture, Azure Security and Communities in general, but it also contains all related links for the Azure certifications and training resources, as well as specific guides and experiences.

Reason: There is no awesome list für Azure certs yet available and even no Azure page on your list, yet. (which I found strange)

I wish you a great Sunday left!

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@radek-sprta
Copy link
Contributor

Couple of highlights from the list guidelines:

  • You have to review at least 2 other open pull requests.
  • Has been around for at least 30 days.
  • The repo should have awesome-list & awesome as GitHub topics.
  • Has a Table of Contents section. Should be the first section in the list. Should only have one level of nested lists, preferably none.
  • Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
  • The link and description are separated by a dash.

@bernardoduarte
Copy link

bernardoduarte commented Mar 10, 2020

The Table of Contents seems to be wrong. It references itself and states that everything resides inside it. I think you should change it to:

Contents

Contributing section have been slashed to mark that it should be removed to adhere to awesome-lint.

@ddneves
Copy link
Author

ddneves commented Mar 10, 2020

Thanks for the feedback. I updated the page. Anything severe missed?

@rajasegar
Copy link

rajasegar commented Mar 17, 2020

You can also remove the top level heading for the Contents section like Awesome Azure Learning Awesome

@cdosoftei
Copy link

Thanks for contributing!

A few observations:

  • The repository has not been around for too long (e.g. a minimum of 30 days, this will be met in a couple of days);
  • Don't clone/copy the awesome badge, use the one supplied by the Awesome project;
  • Make sure ToC entries are matching the section names (e.g. Spotlight (highlighted links) != Spotlight).

@cdosoftei cdosoftei mentioned this pull request Mar 30, 2020
@msmolyakov
Copy link
Contributor

Please do this step:

Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.

There are many errors:

  • Invalid badge source
  • ToC item "Spotlight (highlighted links)" does not match corresponding heading "Spotlight"
  • Invalid list item link URL
  • Rules should use ---

@msmolyakov msmolyakov mentioned this pull request Apr 8, 2020
@loonaticx
Copy link

You can't have "Awesome" in your title, sorry.

@loonaticx loonaticx mentioned this pull request Apr 12, 2020
@sindresorhus
Copy link
Owner

Bump :)

@ddneves
Copy link
Author

ddneves commented Jun 2, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants