-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Software Engineering for Machine Learning #1722
Conversation
This [list](https://github.com/SE-ML/awesome-seml/blob/master/readme.md ) includes articles recommending or describing software engineering best practices for building machine learning applications. It is more than 30 days old and has over 330 stars.
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Hi @sindresorhus, thank you for the review. We actually went to the process again several times and could only identify 2 issues:
If possible, can you be more descriptive about the issues you observed? Thanks! |
@NullConvergence Here is an example of one that was missed:
|
Great, many thanks for your comments! |
unicorn |
Hi, the list is great, I love the use of icons. I noticed the repo is missing a license, which is a requirement:
|
I think you are wrong, the list has a license. |
unicorn |
I see that you listed the license in the readme, the instructions state:
|
@LTCHRIS you are right! I also added the license file. |
|
|
Hi @sindresorhus, thanks for your comment. We've updated the list, although did not implemented the dash between the items and the description. We would like to avoid this change because our description only consists of some icons. Let me know your opinion. |
unicorn |
👋 @NullConvergence The issue "List item link and description must be separated with a dash" only seems to appear for lines that contain ⭐️. Replacing this character with ⭐allows the linter to pass. The difference is subtle. The star you are using have the "unicode variation selector 16" Yours (⭐️): E2AD90EF B88F I have submitted a PR to https://github.com/SE-ML/awesome-seml/ in SE-ML/awesome-seml#11 . Accepting that will further align with the awesome-lint requirements. |
@machawk1 many thanks for suggesting this edit. I accepted your PR! |
Descriptions are missing for the items in the |
I decided to rename |
This list includes articles recommending or describing software engineering best practices for building machine learning applications.
It is more than 30 days old and has over 330 stars.
We reviewed 2 PRs: 1 and 2.
Some linting issues were ignored because the emojis used to flag publications as academic or must-read (see list) are not considered a description.
https://github.com/SE-ML/awesome-seml/blob/master/readme.md
Software engineering is complementary to any machine learning project. Ensuring good software engineering practices enhances development, deployment and maintenance of production level machine learning models. Until now, there is no awesome list to tackle this topic.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.