Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k6 #1721

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Add k6 #1721

merged 2 commits into from
Mar 9, 2020

Conversation

simskij
Copy link
Contributor

@simskij simskij commented Feb 29, 2020

https://github.com/k6io/awesome-k6

This list contains resources about the popular open-source, developer-centric performance monitoring and load testing solution k6.

@simskij
Copy link
Contributor Author

simskij commented Feb 29, 2020

unicorn

@simskij
Copy link
Contributor Author

simskij commented Feb 29, 2020

PR reviews:
#1720
#1699

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@simskij
Copy link
Contributor Author

simskij commented Mar 1, 2020

@sindresorhus, unsure what that would be? It passes awesome-lint, has a detected license, CoC and contribution file.

@radek-sprta
Copy link
Contributor

Just couple things I've noticed:
This line does not end with a period: - k6-typescript-framework - Example of a k6 load testing framework written in TypeScript
Includes seemingly empty repository: https://github.com/loadimpact/k6-gitlab-example

@simskij
Copy link
Contributor Author

simskij commented Mar 7, 2020

Thank you for the pointers! Adjusted.

@chrislatorres
Copy link
Contributor

I see a few k6 and K6 , the guideline wants consistent naming:

Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

@chrislatorres chrislatorres mentioned this pull request Mar 8, 2020
@simskij
Copy link
Contributor Author

simskij commented Mar 8, 2020

I see a few k6 and K6 , the guideline wants consistent naming:

Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

The actual name is k6, but the linter prevents me from using that in the header, unfortunately, due to title casing rules. That is also the only place where it's not k6, so no - there are no inconsistencies in naming.

@sindresorhus
Copy link
Owner

The actual name is k6, but the linter prevents me from using that in the header, unfortunately

You can ignore linter rules when they're wrong: https://github.com/sindresorhus/awesome-lint#special-comments

@sindresorhus
Copy link
Owner

The image should be high-DPI. Set it to maximum half the width of the original image. - https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md

@simskij
Copy link
Contributor Author

simskij commented Mar 9, 2020

The image should be high-DPI. Set it to maximum half the width of the original image. - https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md

Fixed! Thanks for the feedback!

@simskij
Copy link
Contributor Author

simskij commented Mar 9, 2020

The actual name is k6, but the linter prevents me from using that in the header, unfortunately

You can ignore linter rules when they're wrong: https://github.com/sindresorhus/awesome-lint#special-comments

Fixed! Thanks for the feedback!

@sindresorhus sindresorhus merged commit ab786b5 into sindresorhus:master Mar 9, 2020
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1236975875049963520

@radek-sprta radek-sprta mentioned this pull request Mar 26, 2020
DejanPerovic pushed a commit to DejanPerovic/awesome that referenced this pull request Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants