Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blaze #1643

Closed
wants to merge 1 commit into from
Closed

Add Blaze #1643

wants to merge 1 commit into from

Conversation

uabua
Copy link

@uabua uabua commented Oct 26, 2019

This pull request adds Blaze into the Front-End Development category.

https://github.com/arggh/awesome-blaze

Blaze is a powerful library for creating user interfaces by writing reactive HTML templates. Compared to using a combination of traditional templates and jQuery, Blaze eliminates the need for all the “update logic” in your app that listens for data changes and manipulates the DOM. Instead, familiar template directives like {{#if}} and {{#each}} integrates with Tracker’s “transparent reactivity” and Minimongo’s database cursors so that the DOM updates automatically.

Note: The current state of the awesome-blaze repository does not meet the standards to be put into the Awesome list, however I have made a pull request solely to resolve the case.

PR Reviews:

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
    • WTFPL and Unlicense are not acceptable licenses.
    • If you use a license badge, it should be SVG, not PNG.
    • To verify that you've read all the guidelines, please add comment with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

Add Awesome Blaze into the Front-End Development category.
@uabua
Copy link
Author

uabua commented Oct 26, 2019

unicorn

@matheusgmaia
Copy link

Looks OK if PR is accepted.

@caufieldjh
Copy link
Contributor

caufieldjh commented Oct 27, 2019

As per the list:

Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.

It looks like there is a substantial amount of content on this list, so it would be nice to see it cleaned up a bit and have some more project descriptions added. Looks like some of the projects aren't maintained anymore either, which is certainly nice to know but may merit trimming them from the list.

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@sindresorhus
Copy link
Owner

Looks OK if PR is accepted.

@matheusgmaia Please spend some more effort on reviewing.

@uabua
Copy link
Author

uabua commented Oct 28, 2019

@caufieldjh @sindresorhus Your criticism is taken and appreciated.

I explicitly stated on this pull request a special note indicating the state of the added Awesome list.

Note: The current state of the awesome-blaze repository does not meet the standards to be put into the Awesome list, however I have made a pull request solely to resolve the case.

I applied considerable amount of changes to transform awesome-blaze list into a suitable addition to be included in this repository. Of course, per guidelines, - it is mandatory to submit an addition that already fulfills all of the requirements and on that you are completely correct. I thought this pull request could be on hold while the awesome-blaze's maintainer decides to accept the changes I made or not.

I replied in this manner mostly because of this comment:

@matheusgmaia Please spend some more effort on reviewing.

Most probably, - he meant this pull request, not the one I am currently commenting on. I don't want this person to feel guilty for taking time and reviewing the pull request thoroughly, while simultaneously being misjudged in the process.

Thank you for your attention!

Copy link

@cdosoftei cdosoftei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.

The pull request should have not been open, which would invalidate this submission, at least in its current state. For the benefit of future revisions, please address the following (on your tentative fork):

The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.

While awesome and awesome-list are present, there are no list specific topics. The actual repository does feature relevant topics but missed out on the Awesome project ones.

Has an appropriate license.

Consider adding the actual license body to the LICENSE file rather than a mention.

Has a Table of Contents section.

Consider including one more level of nested subsections in the Contents listing (e.g. Official Resources, Jobs etc. under Resources and so on).


Great job!

@sindresorhus
Copy link
Owner

Closing for now. Open a new PR when the list follows all the guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants