-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Blaze #1643
Add Blaze #1643
Conversation
Add Awesome Blaze into the Front-End Development category.
unicorn |
Looks OK if PR is accepted. |
As per the list:
It looks like there is a substantial amount of content on this list, so it would be nice to see it cleaned up a bit and have some more project descriptions added. Looks like some of the projects aren't maintained anymore either, which is certainly nice to know but may merit trimming them from the list. |
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
@matheusgmaia Please spend some more effort on reviewing. |
@caufieldjh @sindresorhus Your criticism is taken and appreciated. I explicitly stated on this pull request a special note indicating the state of the added Awesome list.
I applied considerable amount of changes to transform awesome-blaze list into a suitable addition to be included in this repository. Of course, per guidelines, - it is mandatory to submit an addition that already fulfills all of the requirements and on that you are completely correct. I thought this pull request could be on hold while the awesome-blaze's maintainer decides to accept the changes I made or not. I replied in this manner mostly because of this comment:
Most probably, - he meant this pull request, not the one I am currently commenting on. I don't want this person to feel guilty for taking time and reviewing the pull request thoroughly, while simultaneously being misjudged in the process. Thank you for your attention! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
The pull request should have not been open, which would invalidate this submission, at least in its current state. For the benefit of future revisions, please address the following (on your tentative fork):
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
While awesome
and awesome-list
are present, there are no list specific topics. The actual repository does feature relevant topics but missed out on the Awesome project ones.
Has an appropriate license.
Consider adding the actual license body to the LICENSE file rather than a mention.
Has a Table of Contents section.
Consider including one more level of nested subsections in the Contents listing (e.g. Official Resources, Jobs etc. under Resources and so on).
Great job!
Closing for now. Open a new PR when the list follows all the guidelines. |
This pull request adds Blaze into the Front-End Development category.
https://github.com/arggh/awesome-blaze
Blaze is a powerful library for creating user interfaces by writing reactive HTML templates. Compared to using a combination of traditional templates and jQuery, Blaze eliminates the need for all the “update logic” in your app that listens for data changes and manipulates the DOM. Instead, familiar template directives like
{{#if}}
and{{#each}}
integrates with Tracker’s “transparent reactivity” and Minimongo’s database cursors so that the DOM updates automatically.Note: The current state of the awesome-blaze repository does not meet the standards to be put into the Awesome list, however I have made a pull request solely to resolve the case.
PR Reviews:
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.