-
-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ethereum #1452
Add Ethereum #1452
Conversation
Has 2 reviews. |
Looks good, but it seems that there's another pull request about Ethereum opened: #1429. I don't know what's the way to solve this kind of situations, maybe @sindresorhus can help with this 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the only thing I noticed which could change is that the logo doesn't link to anything.
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
|
Fixed (and added Travis linting) |
Linkify I don't think the The items in the |
Done. I'm very impressed by how in-depth you are! |
The |
The project is called Awesome after all :) |
Thank you for the quick response. |
Awesome, thanks! Added that line-break too |
https://github.com/Tom2718/Awesome-Ethereum
Ethereum is a decentralized platform for creating smart contracts. There are lots of resources available that are outdated and deprecated. This awesome list aims to keep only up-to-date and relevant links. Furthermore, other lists focus too much on bringing publicity to other projects. I don't want this to happen and so won't include any projects being built on top of Ethereum.
Reviewed PRs
1431 Comment
1437 Comment
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Add Name of List
(Example:Add Swift
), notUpdate readme.md
orAdd awesome list
.Example:
- [Fish](…) - User-friendly shell.
, not- [Fish](…) - Resources for Fish.
.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Go to the top and read it again.