-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support in-browser uses #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, is this getting merged soon by any chance? |
I published an alternative package isomorphic-ansi-escapes to temporarily replace this. You can use it before this pr gets merged. |
Hi, thank you! |
sindresorhus
requested changes
Mar 16, 2023
Maybe also mention in the readme that it can be used in the browser with xterm.js |
You're great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for your awesome work!
I'd like to developing a fake shell based on xterm.js in frontend. I found that Vite dev server gives a warning like that:
The
TERM_PROGRAM
env variable also does not exist in browser:According to the Node | Webpack documentation, the webpack can make polyfills for different node functions, but it appears as the node.process is a "mock";
So I added some code to judge the current running environment in advance, and moved some code related to Node to conditional judgment.