DEVEXP-733: Refactor Token Paginator #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asein-sinch
requested review from
matsk-sinch,
Dovchik,
krogers0607 and
JPPortier
as code owners
matsk-sinch
reviewed
Feb 23, 2025
|
|
||
| list_response = token_based_paginator.get_content() | ||
| active_numbers_list = [num.phone_number for num in token_based_paginator.iterator()] |
There was a problem hiding this comment.
The TokenBasedPaginator is a custom iterator that lazily retrieves one item at a time. However, when wrapped with list() or [ ], Python fully consumes the iterator, loading all items into memory at once
To prevent excessive memory usage, you should use lazy iteration with while or for loops instead.
While the current tests handle small data, this practice should be avoided in real-world scenarios. Proper examples and a quickstart guide will be provided soon. However, users exploring the unit tests for reference should not be encouraged to use list().
| async for _ in async_token_based_paginator.iterator(): | ||
| number_counter += 1 | ||
| active_numbers_list = [ | ||
| num.phone_number async for num in async_token_based_paginator.iterator() |
| "PagedResponse", ["result", "has_next_page", "next_page_info", "next_page"] | ||
| ) | ||
|
|
||
| next_page_info = { |
There was a problem hiding this comment.
Shouldn't we keep this info?
|
Information reported in the initial PR by @matsk-sinch . Closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matsk-sinch : Proposal to simplify the implementation and usage of the token paginator