Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: execution strategy changed #34

Merged
merged 1 commit into from
Sep 26, 2024
Merged

CI: execution strategy changed #34

merged 1 commit into from
Sep 26, 2024

Conversation

650elx
Copy link
Contributor

@650elx 650elx commented Sep 24, 2024

Since now we're executing tests against release branches (as opposed to main branch), execution strategy has to be changed.

asein-sinch
asein-sinch reviewed Sep 24, 2024
View reviewed changes
.github/workflows/run-ws.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to delete this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've disabled White Source GH action a while a go.
I was simply not using it. Sorry for not mentioning that in the description of PR.

@asein-sinch
Copy link
Contributor

The CI is failing when trying to clone a private repo. Is your PAT expired?

@650elx
Copy link
Contributor Author

650elx commented Sep 26, 2024

The CI is failing when trying to clone a private repo. Is your PAT expired?

Yeah; there was a temporary issue. It's fixed

@650elx 650elx requested a review from asein-sinch September 26, 2024 12:54
@asein-sinch
Copy link
Contributor

asein-sinch commented Sep 26, 2024 •
edited
Loading

Yeah; there was a temporary issue. It's fixed

Was it an issue on GH side or did you have to perform an action regarding the GH_PAT secret?

@650elx 650elx merged commit be6b973 into main Sep 26, 2024
4 checks passed
@650elx
Copy link
Contributor Author

650elx commented Sep 26, 2024

Yeah; there was a temporary issue. It's fixed

Was it an issue on GH side or did you have to perform an action regarding the GH_PAT secret?

GH_PAT. I have to change that. I'll add ticket to the planning.

@asein-sinch asein-sinch deleted the change_ci_execution_strategy branch February 25, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asein-sinch asein-sinch asein-sinch approved these changes

@Dovchik Dovchik Awaiting requested review from Dovchik Dovchik is a code owner

@krogers0607 krogers0607 Awaiting requested review from krogers0607 krogers0607 is a code owner

@JPPortier JPPortier Awaiting requested review from JPPortier JPPortier is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@650elx @asein-sinch