DEVEXP-340/DEVEXP-471 - automated CI/CD release to PyPI and async library replacement #29
Conversation
650elx
requested review from
Dovchik,
krogers0607,
asein-sinch and
JPPortier
as code owners
650elx
changed the title
.github/workflows/release-sdk.yaml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Release Python SDK |
There was a problem hiding this comment.
I think the name should be Setup Python?
| params=request_data.query_params | ||
| ) | ||
| else: | ||
| response = await self.http_session.request( |
There was a problem hiding this comment.
This part of code looks very similar to the lines 25-31. Maybe you can streamline this by using a single call and handling the content type inline
There was a problem hiding this comment.
This part of code looks very similar to the lines 25-31. Maybe you can streamline this by using a single call and handling the content type inline
I've done it on purpose. Since this is a async context I prefer to keep it simple
sinch/core/adapters/httpx_adapter.py
Outdated
| params=request_data.query_params | ||
| ) | ||
|
|
||
| if response.content: |
There was a problem hiding this comment.
This logic can be rewritten in a more concise way and should manage exceptions when parsing the response
There was a problem hiding this comment.
I've extracted that logic into method (with exception handling) and used it on both transport implementations.
It's not very concise though. I prefer readability here.
* DEVEXP-340/DEVEXP-471 - automated CI/CD release to PyPI and async library replacement (#29) * DEVEXP-464 update verification API with backwards compat (#36) * fix: recursion error (#38) * [SMS] service plan id version of the API (#17) * relese: bump the package version
https://tickets.sinch.com/browse/DEVEXP-340
I've also removed old and unused GH action for white source.
Since DEVEXP-471 was a fallout of DEVEXP-340, I've decided to merge those two tickets into one.