Feat/verification dedicated report for each method #40
Conversation
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace Sinch.Verification.Report.Request | |||
| { | |||
| public class PhoneCallVerificationReportRequest : VerifyReportRequest | |||
| public class ReportPhoneCallVerificationRequest : VerifyReportRequest | |||
There was a problem hiding this comment.
Various options for naming this one:
- phone call
- PSTN call
- callout
In the Node.js SDK, I've chosen callout because:
- it's the method name in the request body
- it's consistent with the Voice API which also uses this term
| @@ -80,17 +80,17 @@ public async Task ReportFlashCallByIdentity() | |||
| [Fact] | |||
| public async Task ReportPhoneCallByIdentity() | |||
There was a problem hiding this comment.
This test title needs to be updated too
| @@ -115,14 +115,14 @@ public async Task StartPhoneCallVerification() | |||
| Identity = _identity, | |||
| Method = VerificationMethodEx.Callout | |||
| }; | |||
| var startPhoneCallVerificationResponse = new StartPhoneCallVerificationResponse | |||
| var startPhoneCallVerificationResponse = new StartCalloutVerificationResponse | |||
There was a problem hiding this comment.
The variable needs to be updated as the function name
| @@ -88,8 +88,8 @@ public async Task ByIdentityPhoneCall() | |||
| await VerificationClient.VerificationStatus.GetByIdentity("+49342432", | |||
| VerificationMethod.Callout); | |||
There was a problem hiding this comment.
The test name needs to be updated https://github.com/sinch/sinch-sdk-dotnet/pull/40/files#diff-8e74407e5b46b5488b4e3b52658cc55f36143ac5c8a7d1d5b6b40ccbeef6bbb2R85
There was a problem hiding this comment.
That's for verification status, which will be a separate PR
|
|
||
| var response = await VerificationClient.Verification.StartCallout(new StartCalloutVerificationRequest | ||
| { | ||
| Identity = startVerificationRequest.Identity, | ||
| Reference = startVerificationRequest.Reference, | ||
| Custom = startVerificationRequest.Custom | ||
| }); | ||
| response.Should().BeEquivalentTo(startPhoneCallVerificationResponse); | ||
| response.Should().BeEquivalentTo(new StartCalloutVerificationResponse |
There was a problem hiding this comment.
Nit: you may recreate a variable startCalloutVerificationResponse as it used to be and as it is in the other tests for consistent reading
Dovchik
deleted the
feat/verification-dedicated-report-for-each-method
branch
Adds dedicated for each method ReportById and ReportByIdentity