Mustermann is not compatible with JRuby --enable=frozen-string-literal param

[brometeo]

It tries to modify a frozen String in the code line:

mustermann-1.1.1/lib/mustermann/ast/node.rb:59

[brometeo]

Any news about this issue? Opinion? :(

[olleolleolle]

@brometeo Would you like to offer a PR?

[olleolleolle]

https://github.com/sinatra/mustermann/blob/master/mustermann/lib/mustermann/ast/node.rb#L111 This line defines a String which is not mutable, and we need it to be. +"" would make a mutable String, whereas "" (the existing code) is a frozen one.

[brometeo]

@brometeo Would you like to offer a PR?

Pull Request? I need permission for updating code :)

[namusyaka]

I'll take a look at this after switching our Ci into actions. Sorry for the late reply.

[michal-granec]

If it's ok with you @namusyaka I can handle the PR for this issue. WDYT?

[dentarg]

Go for it

[michal-granec]

@olleolleolle and @namusyaka PR is ready to be reviewed. Let me know if there is anything I should change, add or try out 😉

[brometeo]

Any news about this issue? It is very annoying :(

[jkowens]

I merged @michal-granec's PR into mustermann master, but we'll need @namusyaka to cut a release to get the fix out.

[jkowens]

Released 1.1.2