Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove numpy dependencies for LLMs extension #1570

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

christophfroeschl
Copy link

@christophfroeschl christophfroeschl commented Jan 31, 2025


Important

Remove numpy dependency from LLM extensions' pyproject.toml files.

  • Dependencies:
    • Remove numpy dependency from pyproject.toml in bedrock, google, and huggingface.
    • Remove numpy dependency from pyproject.toml in ibm, langchain, and local.
    • Remove numpy dependency from pyproject.toml in openai.

This description was created by Ellipsis for ded332a. It will automatically update as commits are pushed.

@christophfroeschl christophfroeschl marked this pull request as ready for review January 31, 2025 13:02
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ded332a in 15 seconds

More details
  • Looked at 84 lines of code in 7 files
  • Skipped 7 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. extensions/llms/bedrock/pyproject.toml:12
  • Draft comment:
    Numpy dependency removed successfully. Ensure that no functionality relying on numpy is broken.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR successfully removes numpy as a dependency from all relevant pyproject.toml files, addressing the issue described.
2. extensions/llms/bedrock/pyproject.toml:12
  • Draft comment:
    Ensure that any changes in dependencies are reflected in the documentation and that corresponding tests are updated or added to verify the changes.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_xjj39zaYeH91UlBx


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ArslanSaleem
Copy link
Collaborator

@christophfroeschl Can you please also update the versions in pyproject.toml files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen dependency of pandasai-openai on numpy
2 participants