Wrap input/textarea in label in textbox component, id and name is not…

… requried
simplystack · Apr 16, 2019 · 89629f9 · 89629f9
1 parent f2f72d1
commit 89629f9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/docs/components/textbox.md b/docs/components/textbox.md
@@ -47,7 +47,7 @@ Textbox is a universal component that can turn into both input and textarea.
 ## Props
 Name | Type   | Description   | Default | Required
 ---- | :----: | ------------- | ------- | --------
-id          | [String, Number] | Unique identifier                      | -       | true
+id          | [String, Number] | Unique identifier                      | -       | false
 name        | String  | Input name                       | -       | false
 value, v-model| [String, Number] | The model that the textbox value syncs to. Can be set initially as a default value. |`''` | false
 type        | String  | Supported values are `text`, `password`, `search`, `email`, `url`, `tel`, and `number`. Only applicable when `multiLine` is `false` | `text` | false

diff --git a/src/components/Textbox/main.vue b/src/components/Textbox/main.vue
@@ -1,6 +1,6 @@
 <template>
-  <div class="textbox">
-    <label :for="id" class="textbox__label">{{ label }}</label>
+  <label class="textbox">
+    <div class="textbox__label">{{ label }}</div>
 
     <input
       v-if="!multiline"
@@ -58,7 +58,7 @@
       class="textbox__textarea"
     ></textarea>
 
-  </div>
+  </label>
 </template>
 
 <script>
@@ -72,11 +72,9 @@ export default {
   props: {
     id: {
       type: [String, Number],
-      required: true,
     },
     name: {
       type: String,
-      required: true,
     },
     label: {
       type: String,