Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional targets_list argument #3

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Conversation

TokRa13
Copy link
Contributor

@TokRa13 TokRa13 commented Jun 28, 2022

https://www.pivotaltracker.com/story/show/170425434

Because we moved tg_attachements from terraform to deploy-tools now we need to manually add targets to target groups when adding new instances.

With this changes we can specify a list of instances instead.

@ptqa
Copy link
Contributor

ptqa commented Jun 28, 2022

I don't really understand the use case for that

@TokRa13
Copy link
Contributor Author

TokRa13 commented Jun 28, 2022

I don't really understand the use case for that

If we add new instances and run deploy from application repo (e.g. simplepractice) - there will be running docker containers on those new hosts but they will not be added as a target to appropriate target groups.

With these changes we can either run manually to change target group like blue_green_switch simplepractice blue 8190 i-0c21ad023330d207b,i-051d6a2bb65c3564f
or change applications deploy code to fetch instances-id automatically as in this example: https://github.com/simplepractice/simplepractice-events/pull/226

@TokRa13
Copy link
Contributor Author

TokRa13 commented Jun 28, 2022

Or we can add targets manually of course... but why do it if we can automate it

@TokRa13 TokRa13 merged commit 6f72764 into master Jun 30, 2022
@TokRa13 TokRa13 deleted the feature/targets-list-arg branch June 30, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants