Feat pwm input update #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update and testing of the PWM input sensor.
I've tested it on f411re nucleo on 16bit and 32bit timers. it seems to work well.
The big change:
Added the PWM frequency parameter to the constructors. The rationale is that in some cases, if the PWM frequency of is low (for example 1kHz) the timer period can be shorter than the PWM period and the overflow can happen.
So I've added a short code that updates the prescaler of the timer to make sure that the timer counter period is always longer than the PWM period (provided in the constructors).
This parameter is optional, and the defualt value is 1kHz that is quite common as far as I know. But this can be changed of course.