Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Deployment from master #2605

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Conversation

rsanheim
Copy link
Contributor

@rsanheim rsanheim commented Jun 17, 2021

This changes our semaphore config to auto promost the master branch to
production for all environments, assuming CI passes and previous
workflows have passed.

When we move to this sort of continous deployment, it doesn't really
make sense to cut tags for every release, because basically every merge
ref will become a release.

I've kept the logic around deploying tags that start with release- for
backwards compatiblity, for times when we want to cut releases by hand
still.

We currently have alerts coming to #alerts and #bots in Slack as things progress through workflows - do we need anything else for good visibility into this?

This changes our semaphore config to auto promost the master branch to
production for all environments, assuming CI passes and previous
workflows have passed.

When we move to this sort of continous deployment, it doesn't really
make sense to cut tags for every release, because basically every merge
ref will become a release.

I've kept the logic around deploying tags that start with `release-` for
backwards compatiblity, for times when we want to cut releases by hand
still.
@rsanheim rsanheim requested a review from a team June 17, 2021 04:36
@rsanheim rsanheim changed the title Continuous Deployment to master Continuous Deployment from master Jun 17, 2021
@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-2605 June 17, 2021 04:38 Inactive
Copy link
Contributor

@harimohanraj89 harimohanraj89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise, this looks solid. Questions:

  • Should we axe the release script?
  • Wanna check with the team during show-and-tell (or later)?

@rsanheim rsanheim temporarily deployed to simple-review-pr-2605 June 17, 2021 17:14 Inactive
@rsanheim
Copy link
Contributor Author

Codewise, this looks solid. Questions:

  • Should we axe the release script?

I think keep around for now in case we want to use it for specific special case releases?

  • Wanna check with the team during show-and-tell (or later)?

Yup I pinged all server-devs in my standup message from yesterday, and from previous discussions I think everyone is on board with giving this a shot.

@timcheadle
Copy link
Contributor

LGTM. I'm in favor of keeping bin/release around until this stabilizes. We should update the README to reflect this auto-promotion.

@rsanheim rsanheim temporarily deployed to simple-review-pr-2605 June 17, 2021 17:26 Inactive
@rsanheim rsanheim merged commit 0bf8c19 into master Jun 17, 2021
@rsanheim rsanheim deleted the continous-deployment-to-master branch June 17, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants