Prevent proton mailboxes from enabling pgp encryption #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenkims
reviewed
Apr 11, 2024
| ) | ||
| else: | ||
| mailbox.disable_pgp = False | ||
| flash(f"PGP is enabled on {mailbox.email}", "info") |
There was a problem hiding this comment.
"enabled" should be "disabled" here I think
There was a problem hiding this comment.
this request is to enable pgp. If we want to enable pgp then disabled has to be set to False. We only force it to True if it's a proton mailbox to disable pgp.
There was a problem hiding this comment.
The disable_x logic is quite confusing. I event had to edit the previous comment twice to get it right.
There was a problem hiding this comment.
ah that's true, I think the reason it was called disable_pgp as I want the default value for a new column is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.