Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require sudo for account changes #2041

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Require sudo for account changes #2041

merged 7 commits into from
Feb 29, 2024

Conversation

acasajus
Copy link
Collaborator

No description provided.

@nguyenkims
Copy link
Contributor

Hey the PR looks good, just some comments on the UI

  1. Can we also move these sections to the new sudo page?
image
  1. Can we add an Account link in the profile screen and remove the account settings button?

CleanShot 2024-02-27 at 22 03 32@2x

  1. Maybe we can rename sudo_setting to account_setting?

@acasajus
Copy link
Collaborator Author

Changed in the last commit.

@acasajus acasajus merged commit 501b225 into master Feb 29, 2024
3 checks passed
@acasajus acasajus deleted the require-sudo-on-account-change branch February 29, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenkims nguyenkims nguyenkims approved these changes

@cquintana92 cquintana92 Awaiting requested review from cquintana92 cquintana92 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acasajus @nguyenkims