Generate working DKIM keys by adding -traditional flag and update NGINX instructions to avoid breaking certbot #1989
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -traditional option to openssl genrsa to avoid Python DKIM library (dkimpy) error that prevents email from being sent: dkim.asn1.ASN1FormatError: Unexpected tag (got 30, expecting 02) Ref: https://bugs.launchpad.net/dkimpy/+bug/1708917
securityguy
requested review from
acasajus,
cquintana92 and
nguyenkims
as code owners
Include warning to delete /etc/nginx/sites-enabled/default to avoid a conflict that breaks certbot.
|
Update NGINX instructions to avoid certbot issues. The default file created when installing NGINX on debian/ubuntu conflicts with the file created in the instructions. Deleting the default file (which is actually a symlink) resolves the issue. |
securityguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -traditional option to openssl genrsa to avoid Python DKIM library (dkimpy) error that prevents email from being sent:
dkim.asn1.ASN1FormatError: Unexpected tag (got 30, expecting 02)
Ref: https://bugs.launchpad.net/dkimpy/+bug/1708917