Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bitwarden icon #12285

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Update Bitwarden icon #12285

merged 1 commit into from
Dec 28, 2024

Conversation

DerBraky
Copy link
Contributor

@DerBraky DerBraky commented Dec 5, 2024

Untitled

Issue: closes #12169

Popularity metric:

  • Similarweb Global Rank: 9,231

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@simple-icons simple-icons bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Dec 5, 2024
adamrusted
adamrusted requested changes Dec 11, 2024
View reviewed changes
icons/bitwarden.svg Show resolved Hide resolved
LitoMore
LitoMore approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've resolved the conflict for you.

@LitoMore LitoMore merged commit a4d36e4 into simple-icons:develop Dec 28, 2024
4 checks passed
@simple-icons simple-icons bot mentioned this pull request Dec 29, 2024
Merged
simple-icons bot added a commit that referenced this pull request Dec 29, 2024
@simple-icons
Release 2 updated icons (v14.0.1)
e10751d 
## 2 updated icons

- Bitwarden (#12285) (@DerBraky)
- dm (#11922) (@DerBraky)

## New entry point `simple-icons/icons.json`

We exposed the `_data/simple-icons.json` as `simple-icons/icons.json` in #12433 (@LitoMore).  Now you can import the JSON file directly instead of using the `getIconsData()`. The `import` way suits more scenes since it has no `fs` calls.

```diff
// CommonJS
-const {getIconsData} = require('simple-icons/sdk');
-const icons = await getIconsData();
+const icons = require('simple-icons/icons.json');
```

```diff
// ESM
-import {getIconsData} from 'simple-icons/sdk';
-const icons = awaiat getIconsData();
+import icons from 'simple-icons/icons.json' with {type: 'json'};
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted requested changes

@LitoMore LitoMore LitoMore approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update: Bitwarden
3 participants
@DerBraky @adamrusted @LitoMore