Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FCC icon #12108

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add FCC icon #12108

merged 2 commits into from
Nov 15, 2024

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Nov 4, 2024

Popularity metric: Similarweb global rank 20913. It is also a symbol that can be seen everywhere in life.

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

This scope discussion is here:

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Nov 4, 2024
uncenter
uncenter requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this would violate the "No governmental agencies, programs, departments" stipulation of https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#requesting-an-icon 👀

_data/simple-icons.json Show resolved Hide resolved
_data/simple-icons.json Show resolved Hide resolved
icons/fcc.svg Outdated Show resolved Hide resolved
@LitoMore
Copy link
Member Author

@uncenter I saw you resolved those threads. Can I get this PR approved?

@LitoMore LitoMore requested a review from uncenter November 15, 2024 23:10
@LitoMore LitoMore merged commit 60e138b into simple-icons:develop Nov 15, 2024
3 checks passed
@LitoMore LitoMore deleted the fcc branch November 15, 2024 23:31
@simple-icons simple-icons bot mentioned this pull request Nov 17, 2024
Merged
simple-icons bot added a commit that referenced this pull request Nov 17, 2024
@simple-icons
Release 4 new icons and 3 updated icons (v13.17.0)
954790c 
# New Icons

- CE (#12109) (@LitoMore)
- ElevenLabs (#11890) (@z-alsamarai)
- FCC (#12108) (@LitoMore)
- Snapdragon (#11852) (@DerBraky)

# Updated Icons

- Lerna (#12092) (@LitoMore)
- Medium (#12124) (@adamlui)
- Signal (#12121) (@uncenter)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncenter uncenter uncenter approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LitoMore @uncenter