Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Telefónica Icon #11468

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

vanshaj-sharma
Copy link
Contributor

image

Issue: closes #11455

Popularity metric:
Similiarweb Global Rank: 50,057

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

I was able to remove the "Telefonica" part in the logo provided at #11455 and also at JSON data, I wrote Telefonica, as Telefónica which was creating issues in linting. Did a simlar sort of a thing in the svg while adding the title tag and also naming the svg. I request the moderators to take a look into this and I will be happy to make changes accordingly if needed

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Jul 13, 2024
@adamrusted
Copy link
Member

@vanshaj-sharma - please tell us what issues you were getting when trying to save with the ó in the name. We can't help if you don't tell us what the issues were :)

icons/telefonica.svg Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
@mondeja mondeja changed the title Added Telefonica Icon Add Telefonica Icon Aug 15, 2024
@mondeja mondeja changed the title Add Telefonica Icon Add Telefónica Icon Aug 15, 2024
@DerBraky
Copy link
Contributor

I just found that there are brand guidelines available. It might be better to include them: https://brandfactory.telefonica.com/document/4201#/telefonica/nuestra-mision

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vanshaj-sharma!

@adamrusted adamrusted merged commit 3bd5fa2 into simple-icons:develop Dec 10, 2024
4 checks passed
simple-icons bot added a commit that referenced this pull request Dec 15, 2024
## 18 new icons

- CaixaBank (#12276) (@8bearings)
- Collabora Online (#11812) (@DerBraky)
- Cryptomator (#11031) (@CodeShakingSheep)
- European Union (#11098) (@uncenter)
- Express.com (#11259) (@anhthang)
- Jio (#11450) (@vanshaj-sharma)
- Nextflow (#12349) (@adamrusted)
- Nintendo DS (#12348) (@adamrusted)
- OCLC (#12279) (@timmy471)
- Omada Cloud (#11074) (@anhthang)
- Paradox Interactive (#11895) (@plvzfq-rit)
- phpBB (#11163) (@CodeShakingSheep)
- Replicate (#11431) (@sebastien46)
- Scalar (#12333) (@antlio)
- Softcatalà (#12145) (@joapuiib)
- Surfshark (#12232) (@mondeja)
- Telefónica (#11468) (@vanshaj-sharma)
- TomTom (#12242) (@mondeja)

## 14 updated icons

- glTF (#12325) (@adamrusted)
- iTerm2 (#12324) (@adamrusted)
- Khronos Group (#12325) (@adamrusted)
- Kia (#12325) (@adamrusted)
- Ko-fi (#11972) (@ameknite)
- OpenGL (#12325) (@adamrusted)
- openHAB (#12325) (@adamrusted)
- Spotify (#12352) (@chrisbegnaud)
- Stripe (#11967) (@koehlertimo)
- TeamViewer (#12327) (@DerBraky)
- Vulkan (#12325) (@adamrusted)
- Vultr (#12325) (@adamrusted)
- WebGL (#12325) (@adamrusted)
- Wii U (#12326) (@jonathansanjay)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Telefónica
4 participants