Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Quizlet icon #10721

Merged
merged 8 commits into from
May 18, 2024
Merged

Add Quizlet icon #10721

merged 8 commits into from
May 18, 2024

Conversation

EricRisher
Copy link
Contributor

@EricRisher EricRisher commented Mar 27, 2024 •
edited
Loading

quizlet

Issue: closes #10718.

Popularity metric: The Similarweb rank is 259 globally. See https://www.similarweb.com/website/quizlet.com/#overview.

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Name

As it appears on their website

Icon

Derived from the official svg icon from https://commons.wikimedia.org/wiki/File:Quizlet_Logo_2021.svg

Color

Extracted from original svg icon color

  • #4255FF

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 27, 2024
@uncenter
Copy link
Member

Did you mean to open both #10720 and this PR?

@uncenter uncenter changed the title added quizlet svg logo Add Quizlet icon Mar 27, 2024
@EricRisher
Copy link
Contributor Author

Did you mean to open both #10720 and this PR?

Sorry this is my first ever pull request on a open source project, opened both by accident.

@uncenter
Copy link
Member

uncenter commented Mar 27, 2024 •
edited
Loading

No worries! Looks like you figured it out :D

I've edited your original comment to fix the checkboxes and link to the original issue. Would you also like to try making a preview image for the icon? See https://wasm.simpleicons.org/preview.

uncenter
uncenter reviewed Mar 27, 2024
View reviewed changes
icons/quizlet.svg Outdated Show resolved Hide resolved
@uncenter
Copy link
Member

uncenter commented Mar 27, 2024 •
edited
Loading

Preview image looks good, nice job! I believe the issue with the SVG (which is making the check fail) is that you have an extra space before viewBox="0 0 24 24".

EricRisher and others added 2 commits March 27, 2024 22:04
@EricRisher
fixed styling test issue
0f01392
@EricRisher @uncenter
Update _data/simple-icons.json
5eda321 
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
@EricRisher EricRisher requested a review from uncenter March 28, 2024 05:07
@EricRisher
Copy link
Contributor Author

Thanks for the help :)

adamrusted
adamrusted requested changes Mar 28, 2024
View reviewed changes
icons/quizlet.svg Outdated Show resolved Hide resolved
adamrusted
adamrusted approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches perfectly to the source on their website, so I'll update that and get this merged in. Thanks @EricRisher!

_data/simple-icons.json Outdated Show resolved Hide resolved
@adamrusted adamrusted merged commit c0eb19b into simple-icons:develop May 18, 2024
3 checks passed
@simple-icons simple-icons bot mentioned this pull request May 19, 2024
Merged
simple-icons bot added a commit that referenced this pull request May 19, 2024
@simple-icons
Release 22 new icons and 5 updated icons (v11.15.0)
1b5de10 
# New Icons

- Buhl (#10919) (@CodeShakingSheep)
- Cal.com (#10908) (@H0onnn)
- Calibre-Web (#10950) (@CodeShakingSheep)
- Dota 2 (#10574) (@ryanmurphyNSCC)
- Fizz (#10873) (@service-paradis)
- FreeCAD (#8879) (@PratyushJayachandran)
- freelancermap (#10946) (@CodeShakingSheep)
- Homarr (#10964) (@CodeShakingSheep)
- Infomaniak (#10930) (@CodeShakingSheep)
- Lemon Squeezy (#10900) (@CodeShakingSheep)
- LimeSurvey (#10901) (@CodeShakingSheep)
- listmonk (#10916) (@CodeShakingSheep)
- MainWP (#10917) (@CodeShakingSheep)
- OpenJS Foundation (#10854) (@10xLaCroixDrinker)
- openmediavault (#10568) (@uncenter)
- Optimism (#10918) (@CodeShakingSheep)
- Quarto (#10960) (@cwickham)
- Quizlet (#10721) (@EricRisher)
- RubyMine (#10707) (@davidlj95)
- Tailscale (#10744) (@mani-sh-reddy)
- Traccar (#10910) (@CodeShakingSheep)
- Twinmotion (#10832) (@uncenter)

# Updated Icons

- Abbvie (#10953) (@jglamp)
- freedesktop.org (#10911) (@uncenter)
- Immich (#10738) (@mani-sh-reddy)
- Lamborghini (#10835) (@PratyushJayachandran)
- Tencent QQ (#10932) (@LitoMore)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@uncenter uncenter Awaiting requested review from uncenter

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Quizlet
3 participants
@EricRisher @uncenter @adamrusted