Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include CarbonAds ad when testing #313

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Nov 10, 2023

Seems that CarbonAds has started to render the ad on locahost. Don't include it when testing because the script is disappearing on a race condition when Puppeteer is requesting it.

@mondeja mondeja added the meta Issues or pull requests regarding the project or repository itself label Nov 10, 2023
@mondeja mondeja merged commit 291d170 into simple-icons:master Nov 10, 2023
3 checks passed
@mondeja mondeja deleted the fix-tests branch November 10, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant