Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LICENSE file #622

Closed
kysrpex opened this issue Apr 29, 2021 · 5 comments · Fixed by #623 or #661
Closed

Update LICENSE file #622

kysrpex opened this issue Apr 29, 2021 · 5 comments · Fixed by #623 or #661
Assignees
@pablo-de-andres @kysrpex @yoavnash
Labels
📖 documentation

Comments

@kysrpex
Copy link
Contributor

kysrpex commented Apr 29, 2021

The LICENSE file should be updated to match the new LICENSE-BSD_3-Clause-template file. I assume that the license on the docs should also be updated, as its content is exactly the same.
@kysrpex kysrpex linked a pull request Apr 29, 2021 that will close this issue
622 Update LICENSE file #623
Merged
3 tasks
@kysrpex
Copy link
Contributor Author

kysrpex commented Apr 29, 2021 •
edited
Loading

@pablo-de-andres @yoavnash Did any other institution actually contribute to OSP-core? Does not seem to be the case according to the commit history. But maybe I am wrong and they are registered as co-authors on some commit's comment.

@yoavnash
Copy link
Member

yoavnash commented Apr 29, 2021 •
edited
Loading

If I'm not mistaken, this is the so-called version 1 of SimPhoNy: https://github.com/simphony/simphony-common
My understanding is that the contributors of this project should also be included

@pablo-de-andres
Copy link
Member

Exactly. Top of my head I can think of Enthought (Didrik Pinte and others)

@yoavnash
Copy link
Member

yoavnash commented Jun 1, 2021

According to Torsten, who compared the contributors to the partner list, we should include Enthought, CIMNE, and University of Jyväskylä.

@kysrpex kysrpex modified the milestone: Sprint #3 Jun 2, 2021
@kysrpex kysrpex mentioned this issue Jun 2, 2021
Closed
@kysrpex kysrpex reopened this Jun 7, 2021
@yoavnash
Copy link
Member

yoavnash commented Jun 7, 2021

Change: have only IWM in the license and mentioned the others in the README file.

@yoavnash yoavnash added this to the v3.5.4-beta milestone Jun 9, 2021
@kysrpex kysrpex linked a pull request Jun 17, 2021 that will close this issue
622 Update license file #661
Merged
@kysrpex kysrpex mentioned this issue Jul 16, 2021
Closed
kysrpex added a commit to simphony/docs that referenced this issue Jul 16, 2021
@kysrpex
Update license information to match the changes that closed OSP-core …
24e4d1b 
…isssue [#622](simphony/simphony-osp#622).
kysrpex pushed a commit to simphony/docs that referenced this issue Jul 16, 2021
@create-issue-branch
Update LICENSE (#170)
3ce25f9 
* Update license information to match the changes that closed OSP-core isssue [#622](simphony/simphony-osp#622).

Authored-by: kysrpex <kysrpex@users.noreply.github.com>
Authored-by: José Manuel Domínguez <jose.manuel.dominguez@iwm.fraunhofer.de>
kysrpex added a commit to simphony/docs that referenced this issue Jul 16, 2021
@kysrpex
Merge sprint #4 (#172)
7720153 
* Update license information to match the changes that closed OSP-core isssue [#622](simphony/simphony-osp#622).

* Bump docs version to 2.4.2 (#171)

Authored-by: kysrpex <kysrpex@users.noreply.github.com>
Authored-by: José Manuel Domínguez <jose.manuel.dominguez@iwm.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pablo-de-andres pablo-de-andres

@kysrpex kysrpex

@yoavnash yoavnash

Labels
📖 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

622 Update LICENSE file simphony/simphony-osp
622 Update license file simphony/simphony-osp
3 participants
@pablo-de-andres @kysrpex @yoavnash