Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CentOS Stream 9 support #179

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

trevor-vaughan
Copy link
Member

  • SSG doesn't have a profile for EL9
  • No SIMP repos for EL9 so those tests won't work
  • Manually verified

spec/acceptance/nodesets/el9.yml Outdated Show resolved Hide resolved
spec/acceptance/nodesets/el9.yml Outdated Show resolved Hide resolved
Copy link

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me.

Gemfile Outdated Show resolved Hide resolved
lib/simp/beaker_helpers.rb Show resolved Hide resolved
@trevor-vaughan trevor-vaughan force-pushed the el9-support branch 5 times, most recently from c3fda42 to c7da4b1 Compare June 17, 2022 19:23
Copy link

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but otherwise this looks ok.

Gemfile Outdated Show resolved Hide resolved
ekohl
ekohl previously approved these changes Jun 17, 2022
@michael-riddle
Copy link
Member

The acceptance tests are failing because they are looking in the following repos:
https://download.simp-project.com/simp/yum/releases/6/el/8/x86_64/BaseOS
https://download.simp-project.com/simp/yum/releases/6/el/8/x86_64/PowerTools

Niether of these repopaths exist under the simp project at that path.

Gemfile Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
@trevor-vaughan
Copy link
Member Author

This seems to work fine as long as the downstream user adds the following to their Gemfile:

gem 'net-ssh', '< 7.0' if Gem::Requirement.create('< 2.6').satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))

Need to get a bunch of stuff done before we can update all of the SIMP modules so this will need to hang out for full release until then.

trevor-vaughan and others added 4 commits October 15, 2022 12:58
* SSG doesn't have a profile for EL9
* No SIMP repos for EL9 so those tests won't work
* Manually verified
* Bump to ruby 2.6 for net-ssh updates
Copy link
Member

@op-ct op-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; worked well with simp/pupmod-simp-simp_firewalld#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

4 participants