Make LDAP client-side TLS authentication optional #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a chance that this could be reviewed sometime soon? |
op-ct
reviewed
Dec 1, 2023
There was a problem hiding this comment.
Hi @sabo, thanks for the contribution!
Sorry for the delay on merging―it's likely because there were no tests to accompany this change in behavior, and it might be a while before the maintainers can get around to adding them.
If you're interested in accelerating the release of this patch: a contribution of tests would be gladly accepted!
|
tests added |
|
Hi, since @sabo added tests could it be reviewed now? Pretty please :) |
|
Does anything else need to happen for this to be reviewed? |
|
@op-ct re-upping this, is the review for this PR waiting on anything else on my end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration option
client_tlstosssd::provider::ldapthat, when set to false, lets SSSD LDAP providers be configured without setting client-side TLS certificate and key options.