Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #289 networkmanager returns null keys for some connections. #290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes #289 networkmanager returns null keys for some connections. #290

wants to merge 2 commits into from

Conversation

dforste
Copy link
Contributor

@dforste dforste commented Aug 30, 2023

Refactor networkmanager connections so connections without a device are addressable. Prevents null keys from being inserted.

@dforste
Update simplib__networkmanager.rb
2219010 
Refactor networkmanager connections so connections without a device are addressable. Prevents null keys from being inserted.
@silug
Copy link
Contributor

silug commented Aug 30, 2023

@dforste Do you have nmcli output that triggers this bug? I'd like to add a test.

@silug silug self-assigned this Aug 30, 2023
@dforste
Copy link
Contributor Author

dforste commented Aug 31, 2023 •
edited
Loading

Example output:

# nmcli connection
NAME           UUID                                  TYPE      DEVICE
System ens160  ea74cf24-c2a2-ecee-3747-a2d76d46f93b  ethernet  ens160
lo             04577901-581b-4cac-bb04-f015fe36274d  loopback  lo
ens160         5780e094-7abe-419a-9c3e-de716150898d  ethernet  --

# nmcli -t connection
System ens160:ea74cf24-c2a2-ecee-3747-a2d76d46f93b:802-3-ethernet:ens160
lo:04577901-581b-4cac-bb04-f015fe36274d:loopback:lo
ens160:5780e094-7abe-419a-9c3e-de716150898d:802-3-ethernet:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@silug silug

Labels
None yet
Projects
Org Triage
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dforste @silug @op-ct