(SIMP-7487) Add EL8 support #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Via updated acceptance tests, verified that the existing configuration worked on EL8 and that EL7 and EL8 interoperate. - Update the upper bound of simp-simplib to < 5.0.0 - Add REFERENCE.md SIMP-7487 #close SIMP-7488 #close SIMP-7436 #close SIMP-7383 #close
|
✔️ Acceptance tests run on a local GitLab |
trevor-vaughan
requested changes
Jan 14, 2020
| @@ -8,6 +8,7 @@ | |||
| skip('You need at least two hosts in your nodeset to run this test') | |||
| end | |||
| else | |||
| # test interoperability between 1st and 2nd server in the node set | |||
| server1 = hosts[0] | |||
There was a problem hiding this comment.
This needs to loop through all hosts and test the interconnections between each pair to make sure all the connections function properly.
| @@ -8,6 +8,7 @@ | |||
| skip('You need at least two hosts in your nodeset to run this test') | |||
| end | |||
| else | |||
| # test interoperability between 1st and 2nd server in the node set | |||
| server1 = hosts[0] | |||
There was a problem hiding this comment.
This also needs to loop through all combinations.
|
This has an example of the pairing loops https://github.com/simp/pupmod-simp-stunnel/blob/master/spec/acceptance/suites/default/20_connectivity_spec.rb#L18 |
|
✔️ Acceptance tests run on a local GitLab |
trevor-vaughan
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configuration worked on EL8 and that EL7 and EL8 interoperate.
SIMP-7487 #close
SIMP-7488 #close
SIMP-7436 #close
SIMP-7383 #close