Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build system and support new rgb syntax #327

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Update build system and support new rgb syntax #327

merged 4 commits into from
Sep 28, 2023

Conversation

simonwep
Copy link
Owner

@simonwep simonwep commented Sep 27, 2023

Summary

  • Update build system and all dependencies to their latest version (still using webpack).
  • Change how color values are interpreted:
    • It's no longer important to use hsva or rgba when providing an alpha value (see mdn).
    • Support percentages for the r, g, b and alpha value of rgba.

Fixes #326

@simonwep simonwep self-assigned this Sep 27, 2023
@simonwep
Copy link
Owner Author

@guivr you can check out this PR locally and use a package like serve to serve the root directory. You can try the values from your issue #326 to see if that's what you wanted :) If everything is alright, I'd merge this issue and release a new patch version.

@guivr
Copy link

guivr commented Sep 27, 2023

Amazing @simonwep! Yes, RGB is working great.

Could you please also add support for this hsl(a):
hsl(0 80% 50% / 25%)
mdn for hsl

Thanks!

@simonwep
Copy link
Owner Author

simonwep commented Sep 28, 2023

Amazing @simonwep! Yes, RGB is working great.

Could you please also add support for this hsl(a): hsl(0 80% 50% / 25%) mdn for hsl

Thanks!

@guivr Done, didn't see that this was a thing now as well. Percentages are now supported for both the alpha value of hsv and hsl :)

@guivr
Copy link

guivr commented Sep 28, 2023

Hi @simonwep! Thanks :)

Works well 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for the new RGB syntax
2 participants