Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jinja2_environment_from_request() plugin hook #2227

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

simonw
Copy link
Owner

@simonw simonw commented Jan 5, 2024

TODO:

  • Documentation, including example showing environment.overlay()
  • Test coverage

With stub tests and documentation so far.

Refs #2225
@simonw simonw added the plugins label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45b88f2) 92.62% compared to head (4ebc99c) 92.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2227      +/-   ##
==========================================
+ Coverage   92.62%   92.64%   +0.01%     
==========================================
  Files          40       40              
  Lines        6075     6090      +15     
==========================================
+ Hits         5627     5642      +15     
  Misses        448      448              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonw
Copy link
Owner Author

simonw commented Jan 5, 2024

@simonw simonw merged commit c7a4706 into main Jan 5, 2024
19 checks passed
@simonw simonw deleted the jinja2_environment_from_request branch January 5, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant