Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow/fix warnings that are blocking CI #269

Merged
merged 2 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

- name: Run cargo-tarpaulin
run: |
cargo +nightly tarpaulin --manifest-path fitsio/Cargo.toml --verbose --timeout 120 --out Lcov
cargo +nightly tarpaulin --manifest-path fitsio/Cargo.toml --verbose --timeout 120 --out lcov

- name: Coveralls
uses: coverallsapp/github-action@master
Expand Down
4 changes: 2 additions & 2 deletions fitsio/src/ndarray_compat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ mod tests {
let phdu = f.primary_hdu().unwrap();

let data: ArrayD<f64> = phdu.read_image(&mut f).unwrap();
let dim = data.dim();
let _dim = data.dim();
assert_eq!(data.ndim(), 3);
assert_eq!(data.shape(), &[2, 3, 6]);
assert_eq!(data[[1, 1, 0]], 24.0);
Expand Down Expand Up @@ -405,7 +405,7 @@ mod tests {
let phdu = f.primary_hdu().unwrap();

let data: ArrayD<f64> = phdu.read_image(&mut f).unwrap();
let dim = data.dim();
let _dim = data.dim();
assert_eq!(data.ndim(), 4);
assert_eq!(data.shape(), &[2, 3, 3, 2]);
assert_eq!(data[[1, 1, 2, 1]], 29.0);
Expand Down
1 change: 1 addition & 0 deletions fitsio/src/threadsafe_fitsfile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ impl FitsFile {
[fits-file]: ../fitsfile/struct.FitsFile.html
*/
pub fn threadsafe(self) -> ThreadsafeFitsFile {
#[allow(clippy::arc_with_non_send_sync)]
ThreadsafeFitsFile(Arc::new(Mutex::new(self)))
}
}
Expand Down
Loading