Provide aliases to function "long names". #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for adding this. I'm not sure I agree with this code being in this crate - this crate is meant to be a minimal ffi wrapper of the original c lib, with "value-adds" in Would it be possible to crate a follow-on PR that provides a means to autogenerate this file, that we can integrate into the |
|
Thanks for merging. I'm thinking about how to generate that file automatically; I think I have a solution, but I'll need some "idle time" to try it out. |
This was referenced Jul 22, 2024
Merged
simonrw
added a commit
that referenced
this pull request
Jul 26, 2024
## 🤖 New release * `fitsio`: 0.21.2 -> 0.21.3 * `fitsio-sys`: 0.5.2 -> 0.5.3 * `fitsio-derive`: 0.2.0 -> 0.2.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `fitsio` <blockquote> ## [0.21.3](fitsio-v0.21.2...fitsio-v0.21.3) - 2024-07-26 ### Added - POC header comment API design ([#332](#332)) ### Other - Add TSHORT types for i16 and u16 - Add clippy feature - Merge branch 'main' into main - Pin minimal serde version - Update criterion requirement from 0.3.5 to 0.5.1 in /fitsio - Fix nightly compile errors - Use TBYTE for *8 reads ([#277](#277)) - Allow/fix warnings that are blocking CI </blockquote> ## `fitsio-sys` <blockquote> ## [0.5.3](fitsio-sys-v0.5.2...fitsio-sys-v0.5.3) - 2024-07-26 ### Other - Fix clippy warnings - Update bindgen requirement from 0.66 to 0.69 in /fitsio-sys - Include new changelog for fitsio-sys - Provide aliases to function "long names". - Update bindgen requirement from 0.63 to 0.66 in /fitsio-sys ### Added * Added aliases for cfitsio short names ([#258](#258)) ### Changed ### Removed </blockquote> ## `fitsio-derive` <blockquote> ## [0.2.1](fitsio-derive-v0.2.0...fitsio-derive-v0.2.1) - 2024-07-26 ### Other - Rename myself - Specify required patch versions for all deps. </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Simon Walker <s.r.walker101@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @simonrw, I hope this finds you well.
I have a (hopefully) simple PR here. I copy+pasted the
longnam.hfile already in the repo and ran a macro over it, which allowsfitsio-sysusers to use the "long names" of the fitsio functions. I quickly tested on another local repo and it appears to work. Not sure what's up withffourl, but I'd consider that function a pretty esoteric one.Let me know what you think, cheers.