Handle different key types #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
force-pushed
the
fix/167/different-key-types
branch
3 times, most recently
from
2932fea
to
80a576a
Compare
We should not use `fits_read_key_log` since this reads a "logical" i.e. boolean.
So we don't have to perform a cast as well as the comparison.
This is needed to test _reading_ boolean header values of both true and false.
simonrw
force-pushed
the
fix/167/different-key-types
branch
from
14cd802
to
584c18a
Compare
simonrw
force-pushed
the
main
branch
3 times, most recently
from
24ecf3c
to
3139d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#167