Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esprima is not automatically installed #43

Open
berkes opened this issue Dec 2, 2022 · 4 comments
Open

esprima is not automatically installed #43

berkes opened this issue Dec 2, 2022 · 4 comments

Comments

@berkes
Copy link

berkes commented Dec 2, 2022

When I run 4.0.0 using the example from the readme, npx then it fails with

Error: Cannot find module 'esprima'

Installing with npm install code-complexity also does not pull it in. Explicitly installing with npm install esprima solves the issue.

I'm no nodejs expert, so I don't know how to present a fix for this -I'm not familiar with bundleDependencies- but I suspect something in the package.json is off, or some vendored package should be included.

@cope
Copy link

cope commented Jan 15, 2023

Probably did not execute npm pack before publishing?

See bundleDependencies.

@rluvaton
Copy link
Contributor

rluvaton commented Mar 1, 2023

@simonrenoult could you please republish with esprima?

adrienjoly added a commit to openwhyd/openwhyd that referenced this issue Jul 18, 2023
@adrienjoly
Copy link

Apparently, this problem appeared in v4.3.0, because v4.2.2 is still working on my end.

@RonaldZielaznicki
Copy link

The root of this problem stems from escomplex. escomplex/escomplex#206

escomplexV2.0.0-alpha (commit) is the version referenced here and on npm. That versions package.json has esprima as a devDependency rather than a dependency.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants