Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in more messaging while downloading #4

Closed
ismayc opened this issue Apr 27, 2020 · 5 comments
Closed

Add in more messaging while downloading #4

ismayc opened this issue Apr 27, 2020 · 5 comments

Comments

@ismayc
Copy link

ismayc commented Apr 27, 2020

Love that this is back on CRAN! Congrats on getting it up there again, Simon!

Given it does take some time to download data, could some messages be added letting users know of where they are in the process? Something like

Downloading flights data for SEA

@ismayc
Copy link
Author

ismayc commented Apr 27, 2020

Might be nice to also tell users how long it took for each of the items to download when using anyflights() so they could plan accordingly on other airport downloads too?

@simonpcouch
Copy link
Owner

Thanks @ismayc! Really appreciate both of these ideas, and will put some time in on adding some messaging in here soon.

@simonpcouch
Copy link
Owner

Thanks again for the issue, @ismayc! Was conflicted about what progress updates should look like, but the idea of just supplying what's currently being downloaded and the elapsed time to that point was a really fitting approach.

Progress updates have been implemented on develop for get_flights() and anyflights()—let me know if you have any thoughts!

@ismayc
Copy link
Author

ismayc commented Apr 30, 2020

Nice! That's pretty slick. Here it is in action: https://www.loom.com/share/e39f6ab35aec4b1bb4ddc16d2fc5f0a5

@ismayc
Copy link
Author

ismayc commented Apr 30, 2020

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants