Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: turning on valuation with V key resets valuation date to "end" #2084

Closed
simonmichael opened this issue Sep 11, 2023 · 2 comments
Closed

ui: turning on valuation with V key resets valuation date to "end" #2084

simonmichael opened this issue Sep 11, 2023 · 2 comments
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. ui The hledger-ui tool. valuation

Comments

@simonmichael
Copy link
Owner

If you started hledger-ui with --value=then, after pressing the V key twice it will be as if you had started it with --value=end.
@simonmichael simonmichael added A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. ui The hledger-ui tool. valuation labels Sep 11, 2023
simonmichael added a commit that referenced this issue Sep 11, 2023
@simonmichael
;doc:journal: clarify valuation date, note bug #2084
4a2da0b
simonmichael added a commit that referenced this issue Sep 12, 2023
@simonmichael
fix:ui: V key preserves startup valuation, if any (fix #2084)
7582460 
Also: hledger-ui cost/value doc improvement and a useful cost/value test file.
@simonmichael
Copy link
Owner Author

Fixed in master.

@jbrains
Copy link
Contributor

jbrains commented Oct 8, 2023

It seems to me like it works. If I notice anything strange with this behavior, I'll comment here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. ui The hledger-ui tool. valuation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonmichael @jbrains