Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch updates for Gramians #30

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Add batch updates for Gramians #30

merged 3 commits into from
Dec 6, 2024

Conversation

simon-hirsch
Copy link
Owner

@simon-hirsch simon-hirsch commented Dec 1, 2024

This PR adds the possibility to batch-update the gramian matrices to the package. This is the first step towards proper (mini-) batch updates in our package.

This PR additionally adds a whole lot of testing around the Gramian matrices, including verifying that

  • plain single step updates work as expected
  • batch updates work as expected

for

  • multiple dimensions
  • multiple forgets
  • constant and random weights

@simon-hirsch simon-hirsch requested a review from BerriJ December 1, 2024 20:15
Copy link
Collaborator

@BerriJ BerriJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for directly adding tests.

@simon-hirsch simon-hirsch merged commit 38bd9ce into main Dec 6, 2024
12 checks passed
@simon-hirsch simon-hirsch deleted the batch_gram_updates branch December 6, 2024 08:42
@simon-hirsch simon-hirsch mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants