Merge pull request #1 from simatic-ax/create-new-feature

Create new feature
simatic-ax · Mar 13, 2024 · 7c81e43 · 7c81e43
2 parents 6ac29be + a122460
commit 7c81e43
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/ProcessControl/ProcessHandling.st b/src/ProcessControl/ProcessHandling.st
@@ -47,7 +47,7 @@ NAMESPACE Simatic.Ax.Process
         /// edge of the machine clock.
         METHOD PROTECTED ProcessFinished : BOOL
 
-            IF (machineClock.QRis() AND _processStarted) THEN
+            IF (machineClock.QFal() AND _processStarted) THEN
                 ProcessFinished := TRUE;
                 _processStarted := FALSE;
                 RETURN;

diff --git a/test/Process/TestProcess.st b/test/Process/TestProcess.st
@@ -10,7 +10,7 @@ NAMESPACE Simatic.Ax.Process
             p : ProcessHandler;
             pStateLess : ProcessHandler;
             risingSignalMock : BinSignalRisingEdgeMock;
-            fallingSignalMock : BinSignalRisingEdgeMock;
+            fallingSignalMock : BinSignalFallingEdgeMock;
         END_VAR
 
         {TestSetup}
@@ -19,9 +19,9 @@ NAMESPACE Simatic.Ax.Process
             p.TimeProvider := timeProvider;
         END_METHOD
 
-        {Test}
-        METHOD PUBLIC Process_Finished_OnRisingEdgeOfMachineClock
-            p.machineClock := risingSignalMock;
+        {Test} // This test checks the finished process on falling edge of the next clock signal
+        METHOD PUBLIC Process_Finished_OnfallingEdgeOfMachineClock  // change to falling edge
+            p.machineClock := fallingSignalMock;
             p.Start();
             AxUnit.Assert.Equal(actual := p.GetState(), expected := ProcessState#Fill);
             p.Execute();